fix: Unregister callbacks when the database (and callbacks) are dropped #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old db callbacks aren't being unregistered now, so dropping the db may result in dropped version change closure being called. Add unregistering callbacks, if they were set by us. Co-authored-by: Yiannis Marangos <[email protected]>
fl0rek
changed the title
devashishdxt
reviewed
Aug 8, 2024
|
@devashishdxt I'm going to close this one as the I'm still worried this is a bit of a footgun, maybe there should be note about dropping |
|
Thanks @fl0rek. Please feel free to open a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #23 we encountered this problem when porting to rexie 0.6
Old db callbacks aren't being unregistered now, so dropping the db may result in dropped version change closure being called. Add unregistering callbacks, if they were set by us.