Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some issues #231

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix some issues #231

wants to merge 2 commits into from

Conversation

skbeh
Copy link
Contributor

@skbeh skbeh commented Oct 5, 2022

  1. Automatically detect libturbojpeg linking arguments.
  2. Fixed a data race with a_running and v_running when exiting.
  3. Automatically try next v4l2 dev when failing to set pixel format.
  4. Not reset gtk widgets when gtk main loop has stopped.
  5. Wait until battery level info is received (currently always 1s),
    because level info is actually sent later so mostly recv
    returns before the client sends.

@aramg
Copy link
Collaborator

aramg commented Mar 8, 2023

Most of these changes looks fine, however

  • usbmuxd-2.0 is not available on Ubuntu (from what I can see), its still just libusbmuxd.
  • libjpeg-turbo is statically linked on purpose, this has been the most consistent way to get the correct library across distros.
  • The battery parsing code doesn't seem to be any better with the given changes, its very hacky to begin with and I would not change it unless making significant changes on how its accomplished in the first place.

1. Automatically detect libturbojpeg linking arguments.
2. Fixed a data race with `a_running` and `v_running` when exiting.
3. Automatically try next v4l2 dev when failing to set pixel format.
1. Not reset gtk widgets when gtk main loop has stopped.
2. Wait until battery level info is received (currently always 1s),
   because level info is actually sent later so mostly `recv`
   returns before the client sends.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants