Add shadcn library

[dEdmishka]

I've added brand new React components library which includes all necessary components, like accordion, form, button e.c.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
messenger-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 21, 2024 1:36pm

[DemianParkhomenko]

I think it is better to add components one by one and only when you need them. Also, components should be already modified according to our design.

[dEdmishka]

I think it is better to add components one by one and only when you need them. Also, components should be already modified according to our design.

Yeap, let's add components when they'll be needed:)

[DemianParkhomenko]

@dEdmishka Is it ready to review?

[dEdmishka]

@dEdmishka Is it ready to review?

Em, it is.

[DemianParkhomenko]

Now build is failed. Please, fix it. You can run npm run build locally to check it.

[dEdmishka]

Now build is failed. Please, fix it. You can run npm run build locally to check it.

Locally everything works great. I don't know, why your build failde. Try run npm install, or something.

[DemianParkhomenko]

I think you should add a component from shadcn, to test how easily (difficult) you can use shadcn. Because now we cannot even check if our "theming" is right, and if does it fit for shadcn. Also, you can replace an existing component with a component from shadcn.

And ideally the diff should not be very big. So then it will be easier to maintain our components. You can run npx shadcn-ui diff to check this.

https://arc.net/l/quote/ntfpiwcp

[dEdmishka]

I think you should add a component from shadcn, to test how easily (difficult) you can use shadcn. Because now we cannot even check if our "theming" is right, and if does it fit for shadcn. Also, you can replace an existing component with a component from shadcn.

And ideally the diff should not be very big. So then it will be easier to maintain our components. You can run npx shadcn-ui diff to check this.

https://arc.net/l/quote/ntfpiwcp

Did you find out why your build failed?

[DemianParkhomenko]

Now build is failed. Please, fix it. You can run npm run build locally to check it.

It fails in GitHub actions. Moreover it fails locally too.

I guess you renamed folder, but forgot to change tsconfig or something like that.

messenger-frontend/tsconfig.json

Line 26 in 9b5c67b

"@/ui/*": ["src/components/ui/*"]

[dEdmishka]

Now build is failed. Please, fix it. You can run npm run build locally to check it.

It fails in GitHub actions. Moreover it fails locally too.

I guess you renamed folder, but forgot to change tsconfig or something like that.

messenger-frontend/tsconfig.json

Line 26 in 9b5c67b

"@/ui/*": ["src/components/ui/*"]

Yes, I changed the folder from incorrect 'UI' to 'ui', and lowercased some folders too, because some folders were lowercased, some not(I don't think that it were the right approach). So, I record these changes to config files too.
Should mention, that GitHub actions really bugged, and it could load changes so long. Also, I propose to remove Vercel build, 'cause no one could see the build on the Vercel site(except you, Demian)

[dEdmishka]

That's it. Returned library configs, tested library button in FormAuth.tsx. And I again checked configs, everything fine and dandy.
@DemianParkhomenko @firehawk89 pls renew your reviews

[dEdmishka]

I've removed bugged alias "@/ui", 'cause in VS Code is simply ignoring it.
Also rechecked all folder names, they should be and they are lowercased, in order to prevent future conflicts.

[firehawk89]

LGTM

[DemianParkhomenko]

@dEdmishka Thanks for PR. Good job! Some minor comments to resolve and you can merge it.

[DemianParkhomenko]

@dEdmishka @firehawk89 WDYT about renaming components files according to shadcn naming convention?

i.e. to kebab case ButtonThemeToggle.tsx -> button-theme-toggle.tsx