Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-Use Simulators #34

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Single-Use Simulators #34

wants to merge 5 commits into from

Conversation

SlaunchaMan
Copy link
Contributor

This PR modifies the runTests action to automatically create a new simulator for each device it’s going to run on. This will prevent tests from interfering with one another, as each test will run in its own environment.

@jshier
Copy link
Contributor

jshier commented Jun 5, 2020

There doesn't seem to be any cleanup in this PR. Also, it would great if the cleanup (along with other cleanup steps) were resilient to failed jobs, as errors in the fastlane run means we don't get the cleanup steps.

@jshier
Copy link
Contributor

jshier commented Jun 5, 2020

I'm also curious what benefits this would bring, as I don't recall any CI issues that would've been helped by having a new simulator for every test run. Is the simulator the only thing that prevents parallel testing runs for multiple CI jobs? Also, have you measured the performance cost of creating and destroying a simulator for every iOS job?

@SlaunchaMan
Copy link
Contributor Author

The included plugin does in fact catch errors during a test run and clean them up, as well as deleting the simulator after each use. The main benefit of doing this is that you get a fresh simulator every time, and if two jobs run in parallel, they will use their own simulators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants