Convert browser tests #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stroy w jsdom test
This reverts commit 3e983b7.
ericyhwang
approved these changes
Jul 11, 2024
| expect(page.nested[0]).instanceof(Item); | ||
| expect(page.nested[0].markerNode.nextSibling).html('<div></div>'); | ||
| expect(fragment).html('<div></div>'); | ||
| }); | ||
|
|
||
| it('HTML element `as-object` property', function() { | ||
| var app = derby.createApp(); | ||
| async function nextTick() { |
There was a problem hiding this comment.
Let's add a comment explaining why this is needed in these tests:
derby/src/templates/templates.ts
Line 2342 in 59db1ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert browser tests to use jsdom based test runner so they are run with other tests.