Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document as-array and as-object #644

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Document as-array and as-object #644

merged 6 commits into from
Jul 3, 2024

Conversation

craigbeck
Copy link
Contributor

Add documentation for as-array and as-object

@craigbeck craigbeck requested a review from ericyhwang July 1, 2024 21:59
ericyhwang
ericyhwang approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@ericyhwang ericyhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some minor wording suggestions, otherwise LGTM

docs/views/template-syntax/view-attributes.md Outdated Show resolved Hide resolved
docs/views/template-syntax/view-attributes.md Outdated Show resolved Hide resolved
docs/views/template-syntax/view-attributes.md Outdated Show resolved Hide resolved
docs/views/template-syntax/view-attributes.md Outdated Show resolved Hide resolved
@craigbeck craigbeck merged commit dff7070 into master Jul 3, 2024
5 checks passed
@craigbeck craigbeck deleted the doc-as-array-as-object branch July 3, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericyhwang ericyhwang ericyhwang approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craigbeck @ericyhwang