Add support for ClusterRule aggregationRule #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@derailed is there anything you want me to change or clarify? |
derailed
requested changes
Aug 26, 2024
There was a problem hiding this comment.
@jordiprats Great catch! Thank you for these updates!!
Please see review comments
| @@ -76,6 +78,16 @@ func (s *ClusterRole) checkStale(ctx context.Context, refs *sync.Map) { | |||
| if s.system.skip(fqn) { | |||
| continue | |||
| } | |||
| partialRole := false | |||
There was a problem hiding this comment.
nit: prefer using the zero value aka var partialRole bool
There was a problem hiding this comment.
sure, same functionality. I can change that
derailed
approved these changes
Sep 14, 2024
There was a problem hiding this comment.
@jordiprats Thank you for the updates! I think we should support matchExp.
We can add in a subsequent PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: #309
This takes into consideration the roles that are used to generate other roles so that they are not marked as unused as per aggregated-clusterroles