Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs : Update README.md #280

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

seonghun-dev
Copy link
Contributor

@seonghun-dev seonghun-dev commented Mar 25, 2024

๐Ÿ“Œ ๋ฐฐ๊ฒฝ

close # Readme ์—…๋ฐ์ดํŠธ

๋‚ด์šฉ

๋ฆฌ๋“œ๋ฏธ ์—…๋ฐ์ดํŠธ ํ–ˆ์–ด์—ฌ

https://github.com/depromeet/street-drop-iOS/blob/e38bcb076c3687e2827214373ee57596c50f9922/README.md

iOS๋Š” ์ž˜๋ชฐ๋ผ์„œ ์„ค๋ช…์€ ๋ชจ๋ฅด๊ฒ ์–ด์š”

@siyeonSon
Copy link
Member

์šฐ์™€์•„ ๐Ÿ˜ฎ๐Ÿ˜ฎ๐Ÿ˜ฎ

@joseph704 joseph704 added the Documentation ๋ฌธ์„œ ์ž‘์„ฑ label May 20, 2024
Copy link
Member

@joseph704 joseph704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์„ฑํ›ˆ๋‹˜ ์ด๋ ‡๊ฒŒ ์ด์˜๊ฒŒ ์ž‘์„ฑํ•ด ์ฃผ์‹œ๋‹ค๋‹ˆ.. ๋ช‡๊ฐ€์ง€๋งŒ ์ˆ˜์ •ํ•ด ์ฃผ์‹œ๋ฉด ๊ฐ์‚ฌํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

Comment on lines +15 to +16
- Architecture: MVVM + Repository (with RxSwift)
- Network LayerL Moya
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Architecture: MVVM + Repository (with RxSwift)
- Network LayerL Moya
- Architecture: Clean Architecture

ํด๋ฆฐ์•„ํ‚คํ…์ฒ˜ ์‚ฌ์šฉ์ค‘์ด๋ผ ๋ณ€๊ฒฝ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค

โ”‚ โ”œโ”€โ”€ Application
โ”‚ โ”œโ”€โ”€ Data
โ”‚ โ”‚ โ”œโ”€โ”€ DataMapping
โ”‚ โ”‚ โ”œโ”€โ”€ FCM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FCM์€ ๋บด์ฃผ์…”๋„ ๋ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค!

โ”‚ โ”‚ โ”œโ”€โ”€ Entity
โ”‚ โ”‚ โ””โ”€โ”€ UseCase
โ”‚ โ”œโ”€โ”€ Network
โ”‚ โ”œโ”€โ”€ Presentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation ํ•˜์œ„์— View๋ž‘ ViewModel ์ž‘์„ฑํ•ด ์ฃผ์‹œ๋ฉด ๊ฐ์‚ฌํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

Comment on lines +49 to +50
#### ๐Ÿ“ฆ Dependency
-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency๋Š” ์•„๋ž˜ Tech Stack์ด๋ž‘ ๊ฒน์น  ๊ฒƒ ๊ฐ™์•„ ์ œ๊ฑฐํ•ด๋„ ๊ดœ์ฐฎ์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation ๋ฌธ์„œ ์ž‘์„ฑ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants