Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 인사말 api 연결 #451

Merged
merged 10 commits into from
Oct 28, 2024
Merged

feat: 인사말 api 연결 #451

merged 10 commits into from
Oct 28, 2024

Conversation

wokbjso
Copy link
Member

@wokbjso wokbjso commented Oct 25, 2024

🤔 어떤 문제가 발생했나요?

🎉 어떻게 해결했나요?

  • 인사말 api를 연결합니다.

📷 이미지 첨부 (Option)

image

⚠️ 유의할 점! (Option)

  • NA

@king2dwellsang king2dwellsang added the feat # Add feature label Oct 25, 2024
@king2dwellsang king2dwellsang added the Review Plz🙏 # Review is not yet complete label Oct 25, 2024
Jungjjeong
Jungjjeong approved these changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@Jungjjeong Jungjjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻
api 호출이 실패했을때 default로 노출될 문장이 있으면 좋을 것 같아요.

@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Oct 27, 2024
@wokbjso wokbjso merged commit 2a54cdc into main Oct 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jungjjeong Jungjjeong Jungjjeong approved these changes

@hjy0951 hjy0951 Awaiting requested review from hjy0951 hjy0951 is a code owner

@summermong summermong Awaiting requested review from summermong summermong is a code owner

Assignees

@wokbjso wokbjso

Labels
Approved 🆗 # Review is completed feat # Add feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wokbjso @Jungjjeong @king2dwellsang