refactor: remove ammonia and additional comrak features #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that denoland/docs#1170 landed, we can now remove ammonia since the features of github-style notes and video & image url embedding are now not needed anymore for any user of this crate besides JSR, so moving all this code over to JSR.
This massively slims down in regards to dependencies.
This does mean that people relying on these two capabilities will have a break in behaviour, however the chance of such existing is extremely low, and was introduced purely due to demand of this for JSR. and if they want this behaviour they should either use the crate or the WASM JSR package.
Ref: jsr-io/jsr#845