refactor(node/npm): separate out permission check from npm resolvers #27511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Dec 31, 2024
| } | ||
|
|
||
| match &self.mode { | ||
| NpmRegistryReadPermissionCheckerMode::Byonm => { |
There was a problem hiding this comment.
Change here was to also have the byonm check here, but other than that the code is the same.
| @@ -76,7 +76,7 @@ async function createDenoDtsFile() { | |||
|
|
|||
| file.insertStatements( | |||
| 0, | |||
| "// Copyright 2018-2024 the Deno authors. MIT license.\n\n", | |||
| "// Copyright 2018-2025 the Deno authors. MIT license.\n\n", | |||
There was a problem hiding this comment.
Nit: seems unrelated to this PR in particular.
marvinhagemeister
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouples permissions from the npm resolvers (towards moving the resolvers out of the cli crate)