refactor: don't use deno.core.ops in jupyter,bench,test,lint #27482
+145
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwhit
commented
Dec 27, 2024
| import { assertThrows } from "./test_util.ts"; | ||
| // import { assertEquals } from "./test_util.ts"; | ||
| //// @ts-expect-error TypeScript (as of 3.7) does not support indexing namespaces by symbol | ||
| // const format = Deno[Deno.internal].jupyter.formatInner; |
There was a problem hiding this comment.
Deno[Deno.internal].jupyter is undefined with this PR, it only gets set up during deno jupyter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs denoland/deno_core#1014
the only remaining issue is the jupyter test that relies on using things from
Deno[Deno.internal].jupyter. That only worked because we always executed40_jupyter.jsfordeno test. With this PR, we only execute what's needed, and sincedeno testdoesn't really need jupyter it isn't available.We can:
40_jupyter.jsduringdeno test