fix(publish): continue publishing with errors #26829
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make sure we still exit with code 1 at the end. |
lucacasonato
previously approved these changes
Nov 12, 2024
|
Actually, I am not sure this works. Doesn't the |
dsherret
requested changes
Nov 12, 2024
There was a problem hiding this comment.
In a workspace of two packages A and B, failure during publishing of package B can lead to provenance step being skipped of package A.
It sounds like we should change the code so that the provenance is verified after publish of package A before moving on to package B.
Also, what issue is this fixing? It would be good to add a test to demonstrate the fix and show the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a workspace of two packages A and B, failure during publishing of package B can lead to provenance step being skipped of package A. This PR makes it print out the error and continue publishing other packages instead of a fast fail.