Added check for incompatible fzf version #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! |
|
您好！您的邮件我已收到，我会尽快的查阅邮件。谢谢您的来信！
|
|
Congrats on merging your first pull request! |
tolik518
changed the title
This was referenced May 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navi currently uses fzf with the parameters
fzf --preview-window up:2:nohiddenwhilenohiddenwas added tofzfin version 0.23.1.Lots of popular distros, like Ubuntu 20.04 or Fedora 30 still distribute fzf 0.20.0 which leads to tickets like #447, #577, or #805.
This PR adds a clear message stating whats wrong instead of forwarding the
invalid preview window layout: up:2:nohiddenerror message to the end user.