Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/kube-downscaler] Cronjob apiVersion compliant post k8s v1.25 #523

Merged
merged 4 commits into from
Sep 21, 2023
Merged

[stable/kube-downscaler] Cronjob apiVersion compliant post k8s v1.25 #523

merged 4 commits into from
Sep 21, 2023

Conversation

dani-CO-CN
Copy link
Contributor

Description

Update the apiVersion generation for Cronjob in kube-downscaler. The current version (batch/v1beta1) will be removed in k8s 1.25. This PR does not break the helm chart for old k8s versions.

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@dani-CO-CN dani-CO-CN requested a review from a team as a code owner September 20, 2023 16:50
max-rocket-internet
max-rocket-internet approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @dani-CO-CN 💚

@max-rocket-internet max-rocket-internet merged commit 64a827d into deliveryhero:master Sep 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dani-CO-CN @max-rocket-internet @dani-rey