Skip to content

Commit

Permalink
[stable/node-local-dns]: support modifying tolerations (#642)
Browse files Browse the repository at this point in the history
feat(node-local-dns): support modifying tolerations
  • Loading branch information
woehrl01 authored Dec 17, 2024
1 parent 11d3c60 commit 374da15
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 10 deletions.
2 changes: 1 addition & 1 deletion stable/node-local-dns/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: node-local-dns
version: 2.1.2
version: 2.1.3
appVersion: 1.23.1
maintainers:
- name: gabrieladt
Expand Down
10 changes: 8 additions & 2 deletions stable/node-local-dns/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# node-local-dns

![Version: 2.1.2](https://img.shields.io/badge/Version-2.1.2-informational?style=flat-square) ![AppVersion: 1.23.1](https://img.shields.io/badge/AppVersion-1.23.1-informational?style=flat-square)
![Version: 2.1.3](https://img.shields.io/badge/Version-2.1.3-informational?style=flat-square) ![AppVersion: 1.23.1](https://img.shields.io/badge/AppVersion-1.23.1-informational?style=flat-square)

A chart to install node-local-dns.

Expand All @@ -23,7 +23,7 @@ helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/node-local-d
To install a specific version of this chart:

```console
helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/node-local-dns --version 2.1.2
helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/node-local-dns --version 2.1.3
```

To install the chart with the release name `my-release`:
Expand Down Expand Up @@ -90,6 +90,12 @@ helm install my-release oci://ghcr.io/deliveryhero/helm-charts/node-local-dns -f
| serviceMonitor.enabled | bool | `false` | Ensure that servicemonitor is created, this will disable prometheus annotations |
| serviceMonitor.metricRelabelings | list | `[]` | Metric relabel configs to apply to samples before ingestion. [Metric Relabeling](https://prometheus.io/docs/prometheus/latest/configuration/configuration/#metric_relabel_configs) |
| serviceMonitor.relabelings | list | `[]` | Relabel configs to apply to samples before ingestion. [Relabeling](https://prometheus.io/docs/prometheus/latest/configuration/configuration/#relabel_config) |
| tolerations[0].key | string | `"CriticalAddonsOnly"` | |
| tolerations[0].operator | string | `"Exists"` | |
| tolerations[1].effect | string | `"NoExecute"` | |
| tolerations[1].operator | string | `"Exists"` | |
| tolerations[2].effect | string | `"NoSchedule"` | |
| tolerations[2].operator | string | `"Exists"` | |

## Maintainers

Expand Down
7 changes: 1 addition & 6 deletions stable/node-local-dns/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,7 @@ spec:
hostNetwork: {{ .Values.config.setupIptables }}
dnsPolicy: Default # Don't use cluster DNS.
tolerations:
- key: "CriticalAddonsOnly"
operator: "Exists"
- effect: "NoExecute"
operator: "Exists"
- effect: "NoSchedule"
operator: "Exists"
{{- toYaml .Values.tolerations | nindent 8 }}
containers:
- name: node-cache
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
Expand Down
10 changes: 9 additions & 1 deletion stable/node-local-dns/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ daemonsetLabels: {}
securityContext:
capabilities:
add:
- NET_ADMIN
- NET_ADMIN

# -- https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/user-guides/getting-started.md
serviceMonitor:
Expand Down Expand Up @@ -133,3 +133,11 @@ imagePullSecrets: []

prometheusScraping:
enabled: true

tolerations:
- key: "CriticalAddonsOnly"
operator: "Exists"
- effect: "NoExecute"
operator: "Exists"
- effect: "NoSchedule"
operator: "Exists"

0 comments on commit 374da15

Please sign in to comment.