Skip to content

Commit

Permalink
Improve torch::jit::as_{module,object} performance (pytorch#84399)
Browse files Browse the repository at this point in the history
This caches the import of `torch.jit.ScriptModule`,
`torch.ScriptObject` and `torch.jit.RecursiveScriptClass`. I measure
a ~0.8 us performance uplift locally when calling a `torch.ops`
function with a `ScriptObject` argument.

Pull Request resolved: pytorch#84399
Approved by: https://github.com/ezyang
  • Loading branch information
peterbell10 authored and pytorchmergebot committed Sep 7, 2022
1 parent 2b2e0fd commit 2feb31c
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions torch/csrc/jit/python/module_python.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,24 @@ namespace torch {
namespace jit {

inline c10::optional<Module> as_module(py::handle obj) {
if (py::isinstance(
obj, py::module::import("torch.jit").attr("ScriptModule"))) {
static py::handle ScriptModule =
py::module::import("torch.jit").attr("ScriptModule");
if (py::isinstance(obj, ScriptModule)) {
return py::cast<Module>(obj.attr("_c"));
}
return c10::nullopt;
}

inline c10::optional<Object> as_object(py::handle obj) {
if (py::isinstance(obj, py::module::import("torch").attr("ScriptObject"))) {
static py::handle ScriptObject =
py::module::import("torch").attr("ScriptObject");
if (py::isinstance(obj, ScriptObject)) {
return py::cast<Object>(obj);
}

if (py::isinstance(
obj, py::module::import("torch.jit").attr("RecursiveScriptClass"))) {
static py::handle RecursiveScriptClass =
py::module::import("torch.jit").attr("RecursiveScriptClass");
if (py::isinstance(obj, RecursiveScriptClass)) {
return py::cast<Object>(obj.attr("_c"));
}
return c10::nullopt;
Expand Down

0 comments on commit 2feb31c

Please sign in to comment.