Fixing a few bugs + use None when missing predictions #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evaluations/evaluation_aragog.py
Outdated
| @@ -153,15 +160,20 @@ def create_args(): | |||
|
|
|||
|
|
|||
| def main(): | |||
| t1 = datetime.datetime.now() | |||
There was a problem hiding this comment.
there's a decorator for that @timeit
There was a problem hiding this comment.
please use the decorator instead
mrm1001
commented
Jun 11, 2024
mrm1001
commented
Jun 11, 2024
| @@ -101,7 +104,10 @@ def run_evaluation(sample_questions, sample_answers, retrieved_contexts, predict | |||
| "sas": eval_pipeline_results['sas'] | |||
| } | |||
|
|
|||
| inputs = {'questions': sample_questions, 'true_answers': sample_answers, 'predicted_answers': predicted_answers} | |||
| inputs = {'questions': sample_questions, | |||
| 'contexts': retrieved_contexts, | |||
There was a problem hiding this comment.
@davidsbatista this is where the contexts are added
davidsbatista
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noneprediction, and ideally this should not affect the scores downstream.contextsto the csv file