-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: list sessions #64
Conversation
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)deepset_cloud_sdk/workflows/sync_client/files.py
deepset_cloud_sdk/workflows/async_client/files.py
deepset_cloud_sdk/workflows/sync_client/utils.py
deepset_cloud_sdk/_service/files_service.py
deepset_cloud_sdk/_api/upload_sessions.py
deepset_cloud_sdk/cli.py
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks real nice!
I tested it out too and works well. Added some mostly docs based comments, one issue I had with the formatting, and one for the flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the following changes will fix it
Co-authored-by: Rohan Janjua <[email protected]>
Co-authored-by: Rohan Janjua <[email protected]>
Related Issues
Proposed Changes?
How did you test it?
Checklist