Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: list sessions #64

Merged
merged 14 commits into from
Jun 9, 2023
Merged

feat: list sessions #64

merged 14 commits into from
Jun 9, 2023

Conversation

ArzelaAscoIi
Copy link
Member

@ArzelaAscoIi ArzelaAscoIi commented Jun 9, 2023

Related Issues

Proposed Changes?

  • list upload sessions via CLI/SDK
  • get upload session via CLI/SDK

How did you test it?

  • unit tests
  • integration tests

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

@deepset-ai deepset-ai deleted a comment from github-actions bot Jun 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Coverage report

The coverage rate went from 96% to 96% ⬇️
The branch rate is 86%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

deepset_cloud_sdk/workflows/sync_client/files.py

100% of new lines are covered (100% of the complete file).

deepset_cloud_sdk/workflows/async_client/files.py

100% of new lines are covered (85% of the complete file).

deepset_cloud_sdk/workflows/sync_client/utils.py

100% of new lines are covered (94% of the complete file).

deepset_cloud_sdk/_service/files_service.py

100% of new lines are covered (97% of the complete file).

deepset_cloud_sdk/_api/upload_sessions.py

100% of new lines are covered (100% of the complete file).

deepset_cloud_sdk/cli.py

100% of new lines are covered (97% of the complete file).

@ArzelaAscoIi ArzelaAscoIi requested a review from rjanjua June 9, 2023 08:48
Copy link
Collaborator

@rjanjua rjanjua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks real nice!

I tested it out too and works well. Added some mostly docs based comments, one issue I had with the formatting, and one for the flow.

tests/unit/service/test_files_service.py Outdated Show resolved Hide resolved
deepset_cloud_sdk/cli.py Outdated Show resolved Hide resolved
deepset_cloud_sdk/workflows/async_client/files.py Outdated Show resolved Hide resolved
deepset_cloud_sdk/cli.py Show resolved Hide resolved
deepset_cloud_sdk/_service/files_service.py Show resolved Hide resolved
@ArzelaAscoIi ArzelaAscoIi requested a review from rjanjua June 9, 2023 11:49
Copy link
Collaborator

@rjanjua rjanjua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the following changes will fix it

deepset_cloud_sdk/cli.py Outdated Show resolved Hide resolved
deepset_cloud_sdk/cli.py Outdated Show resolved Hide resolved
ArzelaAscoIi and others added 2 commits June 9, 2023 15:44
@ArzelaAscoIi ArzelaAscoIi requested a review from rjanjua June 9, 2023 13:45
@ArzelaAscoIi ArzelaAscoIi merged commit ed45916 into main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants