Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retry s3 HTTP 400 #230

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix: retry s3 HTTP 400 #230

merged 2 commits into from
Dec 12, 2024

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented Dec 12, 2024

Related Issues

  • fixes #issue-number

Proposed Changes?

How did you test it?

Notes for the reviewer

Screenshots (optional)

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  deepset_cloud_sdk/_s3
  upload.py
Project Total  

This report was generated by python-coverage-comment-action

@tstadel tstadel merged commit b67857f into main Dec 12, 2024
9 checks passed
@tstadel tstadel deleted the fix/retry_400s branch December 12, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tstadel