Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: explain how to use boolean or list values #186

Merged
merged 2 commits into from
May 6, 2024
Merged

docs: explain how to use boolean or list values #186

merged 2 commits into from
May 6, 2024

Conversation

ArzelaAscoIi
Copy link
Member

Related Issues

Proposed Changes?

  • explalin how to use bool values

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

@ArzelaAscoIi ArzelaAscoIi requested a review from agnieszka-m May 5, 2024 15:32
@swarmia Swarmia
Copy link

swarmia bot commented May 5, 2024

✅  Linked to Bug DC-1128 · Wrong param description

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@ArzelaAscoIi @agnieszka-m
Update deepset_cloud_sdk/cli.py
a235acc 
Co-authored-by: Agnieszka Marzec <[email protected]>
@ArzelaAscoIi ArzelaAscoIi requested a review from agnieszka-m May 6, 2024 07:28
agnieszka-m
agnieszka-m approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@agnieszka-m agnieszka-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ArzelaAscoIi ArzelaAscoIi added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 334ed8c May 6, 2024
9 checks passed
@ArzelaAscoIi ArzelaAscoIi deleted the docs/documentationForBooleanFlags branch May 6, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnieszka-m agnieszka-m agnieszka-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArzelaAscoIi @agnieszka-m