Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error on linux #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix build error on linux #15

wants to merge 1 commit into from

Conversation

csclyde
Copy link

@csclyde csclyde commented Jul 18, 2022

When running the script on Linux, it would fail to create a build. This was because it would throw an unhandled exception when looking for the hl.exe file. The exception is now caught, so the script can not proceed to actually creating the Linux build.

@csclyde
Copy link
Author

csclyde commented Aug 4, 2022

Closed with no comment... is there something different you'd like to see with this? I started my own thing based on redistHelper, because there are a lot of linux problems with redistHelper. Let me know if I can help with the linux build on this one...

@deepnight
Copy link
Owner

Sorry, I just noticed your message here! I don't actually see any real reason for this PR to be closed 🤔

Maybe the try catch could be a little bit closer to the actual exception source (which I guess is findFiles here?). I re-open it: please tell me if you want to change anything, I will just merge it otherwise.

@deepnight deepnight reopened this Sep 6, 2022
@deepnight deepnight self-assigned this Sep 6, 2022
@deepnight deepnight added the bug Something isn't working label Sep 6, 2022
@csclyde
Copy link
Author

csclyde commented Sep 7, 2022

@deepnight Hey, I kept working on this fix for Linux, and it sort of spiraled out into its own thing here:

https://github.com/csclyde/hxdist

I don't yet have 100% of the functionality of your redistHelper (still need setting icons and signing windows exes). But it's pretty close, and it works great on Linux. It's close to working on Mac too, I just need a better test machine to get all the shared libs fixed.

For this PR, I can either just move the try/catch down a little bit like you suggested, or we can maybe merge the two projects somehow.

@csclyde
Copy link
Author

csclyde commented Feb 1, 2023

@deepnight Hey there, I've updated my tool so that it works on all Win/Mac/Linux. Feel free to pull over the .dll, .so, and .dylib files if you please. I've made sure, especially on mac, that they all are set up correctly to look for local executable. My tool also now sets windows icon, file permissions on mac/linux, and creates a run.sh script for Linux so that a package will work perfectly on Steam for Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants