Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support atomwise rmax for sktb module #209

Open
wants to merge 62 commits into
base: main
Choose a base branch
from

Commits on Sep 14, 2024

  1. feat: add logging for self-interaction warnings and implement tests f…

    …or r_max functionality
    QG-phy committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    7cf9323 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Configuration menu
    Copy the full SHA
    4feaf4e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    453a86a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a0524a8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3706df0 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. add Covalent_radii database

    QG-phy committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    60d2b89 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Add support for basis input in the format : ['s','p','d'], previous o…

    …nly support the format of ['2s','3p','d*'], where the main quantum number must be there before the orbital or the * after the orbital symbol.
    QG-phy committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    241f4c7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    955c658 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    93c8dbd View commit details
    Browse the repository at this point in the history
  4. add test_Covalent_radii

    QG-phy committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a5c2722 View commit details
    Browse the repository at this point in the history
  5. add some comment in dftbsk

    QG-phy committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2514fbd View commit details
    Browse the repository at this point in the history
  6. add BondLenCovalent

    QG-phy committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e074b38 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cd66749 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5a98af3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    cced890 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c48612a View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Configuration menu
    Copy the full SHA
    87cf70a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ab6ed11 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    803da72 View commit details
    Browse the repository at this point in the history
  4. feat: Calculate minimum and maximum atomic radii based on skdata

    This commit adds a new function `cal_rmin_rmax` to calculate the minimum and maximum atomic radii based on the given skdata. It uses the `find_first_false` function to find the index of the first occurrence of False in each row of a 2D array. The calculated atomic radii are stored in the `atomic_r_min_dict` and `atomic_r_max_dict` dictionaries.
    QG-phy committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7409e6d View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. add new dftb2nnsk

    QG-phy committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d34a7b1 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. add new dftb2nnsk

    QG-phy committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4ebaa77 View commit details
    Browse the repository at this point in the history
  2. feat: Update SKParam class to update atomic radii and format_skparams…

    … to align the distance introduce the mask for rij out the grid from skfiles.
    
    This commit modifies the SKParam class in sk_param.py to calculate and update the minimum and maximum atomic radii based on the given skdata. It introduces a new function `cal_rmin_rmax` that uses the `find_first_false` function to find the index of the first occurrence of False in each row of a 2D array. The calculated atomic radii are stored in the `atomic_r_min` and `atomic_r_max` attributes of the SKParam class.
    QG-phy committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ce17523 View commit details
    Browse the repository at this point in the history
  3. feat: Add range check for bond distance in HoppingIntp

    This commit adds a range check for the bond distance `rij` in the `HoppingIntp` class of `hopping_dftb.py`. If any `rij` values are outside the interpolation range defined by `min_x` and `max_x`, a warning message is logged and those values are set to 0.0. The interpolated values are then calculated using the modified `rij` array.
    QG-phy committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    f5d0e09 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. feat: Add poly4pow hopping formula to HoppingFormula class and simpli…

    …fy the class
    
    This commit adds the 'poly4pow' hopping formula to the HoppingFormula class in hopping.py. The formula calculates the SK integrals without the environment dependence of the form of powerlaw. It takes into account parameters such as alpha1, alpha2, alpha3, alpha4, alpha5, and alpha6. The function poly4pow() is used to calculate the value of the hopping formula. If the functype is 'NRL0' or 'NRL1', the NRL_HOP method is called. Otherwise, the method corresponding to the functype is called. If the functype is not recognized, a ValueError is raised.
    QG-phy committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6518591 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f2dc9ee View commit details
    Browse the repository at this point in the history
  3. delete temp

    QG-phy committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6d9b212 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Configuration menu
    Copy the full SHA
    b320681 View commit details
    Browse the repository at this point in the history
  2. feat: Add poly3exp and poly4exp hopping formulas to HoppingFormula class

    This commit adds the 'poly3exp' and 'poly4exp' hopping formulas to the HoppingFormula class in hopping.py. These formulas calculate the SK integrals without the environment dependence of the form of powerlaw. They take into account parameters such as alpha1, alpha2, alpha3, alpha4, alpha5, and alpha6. The functions poly3exp() and poly4exp() are used to calculate the values of the hopping formulas. If the functype is 'NRL0' or 'NRL1', the NRL_HOP method is called. Otherwise, the method corresponding to the functype is called. If the functype is not recognized, a ValueError is raised.
    QG-phy committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6a2a4a2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7455959 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c499fdc View commit details
    Browse the repository at this point in the history
  5. feat: Update NNSK class to support bond-wise rs values

    This commit updates the NNSK class in nnsk.py to support bond-wise rs values. It introduces a conditional statement to check if the rs values are atom-wise or bond-wise. If the rs values are bond-wise, the get_r_map_bondwise() function is called to generate the r_map dictionary. The r_map_type attribute is set to 2 to indicate bond-wise rs values. This allows for more flexibility in defining the hopping options for the NNSK model.
    QG-phy committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    4a9cf95 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0fd4422 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    78ac760 View commit details
    Browse the repository at this point in the history
  8. test:update some tests

    QG-phy committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    bec788d View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    afec4a4 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Configuration menu
    Copy the full SHA
    bb46aab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6feeb39 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    23d27b2 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Configuration menu
    Copy the full SHA
    47f75fc View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. Refactor NRL_OVERLAP0 and NRL_OVERLAP1 in hopping.py to use torch.Ten…

    …sor instead of torch.float32 for rs and w parameters
    QG-phy committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    17e53fd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    df83035 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4d2103a View commit details
    Browse the repository at this point in the history
  4. Refactor collectskf.py and main.py to add support for converting sk f…

    …iles to nn-sk TB model
    QG-phy committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    d86a51d View commit details
    Browse the repository at this point in the history
  5. Refactor argcheck.py to add support for RMSprop and LBFGS optimizers …

    …and CosineAnnealingLR learning rate scheduler
    QG-phy committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    5e8afd9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1a9bf31 View commit details
    Browse the repository at this point in the history
  7. update test for dftb2nnsk

    QG-phy committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    5149dea View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7aec1f1 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    cd7407f View commit details
    Browse the repository at this point in the history
  10. Add output inputpara

    QG-phy committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    9aca6e8 View commit details
    Browse the repository at this point in the history
  11. add bond integrl plot viz

    QG-phy committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    fb95814 View commit details
    Browse the repository at this point in the history
  12. add bond integrl plot viz

    QG-phy committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    fdd5e96 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    3cfe8b1 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    b0044ca View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Configuration menu
    Copy the full SHA
    000f9d8 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Configuration menu
    Copy the full SHA
    871c711 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0c5345d View commit details
    Browse the repository at this point in the history
  3. Refactor ElecStruCal class to handle atomic radius options and fix a …

    …bug related to the pbc parameter
    QG-phy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    0038aea View commit details
    Browse the repository at this point in the history
  4. Refactor get_cutoffs_from_model_options function to handle the case w…

    …hen r_max is not provided in dftbsk model options
    QG-phy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    3568650 View commit details
    Browse the repository at this point in the history
  5. add example of dftb2nnsk

    QG-phy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    bc5dcdf View commit details
    Browse the repository at this point in the history
  6. test: add skf2nnsk example

    QG-phy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    3aff70e View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Configuration menu
    Copy the full SHA
    2fa3d22 View commit details
    Browse the repository at this point in the history