Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): default function expression -> dynamic expression #545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcus-sa
Copy link
Contributor

Summary of changes

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

@marcus-sa marcus-sa force-pushed the fix/type-default-function-expression branch from bce2618 to d5c9537 Compare January 24, 2024 13:38
@marcus-sa marcus-sa force-pushed the fix/type-default-function-expression branch from d5c9537 to e4f115c Compare January 24, 2024 13:40
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (ee8f570) 77.88% compared to head (87c62ae) 77.81%.
Report is 1 commits behind head on master.

❗ Current head 87c62ae differs from pull request most recent head e4f115c. Consider uploading reports for the commit e4f115c to get more accurate results

Files Patch % Lines
packages/type/src/reflection/reflection.ts 65.48% 39 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
- Coverage   77.88%   77.81%   -0.08%     
==========================================
  Files         188      188              
  Lines       20143    20201      +58     
  Branches     5244     5274      +30     
==========================================
+ Hits        15689    15719      +30     
- Misses       4454     4482      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcus-sa marcus-sa mentioned this pull request Jan 25, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants