Joseba/scores predsets #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-Mouhcine
reviewed
Oct 19, 2023
There was a problem hiding this comment.
I see that you changed the name of the functions from xxx_interval to xxx_set. Can you please motivate your choice?
I specifically used "interval" for regression and "set" for classification. An interval is basically a set but the naming was voluntarily different to discriminate between the two tasks (reg and classif).
Anyways, this opens us to some issues if we forget to echo the changes in other modules or documentation files. For example, the call to cqr_interval wasn't updated in deel.puncc.regression module (line #429). By the way, how did the code pass the test_regression_seed test for CQR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create difference score function. Rename mad score function to absolute_difference. Create multivariate predset functions which are similar to univariate ones due to numpy broadcasting features, however documentation is different. Will test in the future when the pipeline for multivariate regression is ready and decide if we refactor.