fix(vm): unfreeze fs after snapshot #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniil Antoshin <[email protected]>
danilrwx
force-pushed
the
fix/vm/snapshot-fs-unfreeze
branch
from
295c19a to
2ce36ec
Compare
Isteb4k
requested changes
Dec 9, 2024
images/virtualization-artifact/pkg/controller/vmsnapshot/internal/life_cycle.go
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/snapshot_service.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/snapshot_service.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniil Antoshin <[email protected]>
Isteb4k
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unfreeze vm fs after snapshot
Why do we need it, and what problem does it solve?
Currently, with multiple disks and their snapshots, we do not unfreeze the fs
What is the expected result?
fs unfreeze after all snapshots done
Checklist