Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vd): set tolerations for provisioners #556

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Isteb4k
Copy link
Contributor

@Isteb4k Isteb4k commented Dec 5, 2024

Description

Problem scenario:
Create local virtual disks (available only on the node where they were created) and a virtual machine on the masters, set tolerations and node selectors, but nothing starts because there are no tolerations for the disk provisioners.

Solution:
When creating virtual disks, the tolerations for the disk provisioners are inherited from the virtual machine and virtual machine class.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@Isteb4k Isteb4k force-pushed the fix/api/provisioner-scheduling branch 6 times, most recently from a1132bc to b9227df Compare December 9, 2024 08:22
@Isteb4k Isteb4k marked this pull request as ready for review December 9, 2024 09:16
@Isteb4k Isteb4k force-pushed the fix/api/provisioner-scheduling branch 9 times, most recently from 2d1d973 to 4380a3a Compare December 11, 2024 15:52
@Isteb4k Isteb4k force-pushed the fix/api/provisioner-scheduling branch from 4380a3a to 7b715a2 Compare December 11, 2024 16:52
@Isteb4k Isteb4k changed the title fix(api): set pending phase for vd if provisioner is not scheduled feat(vd): set tolerations for provisioners Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant