Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix scheme for cdi servicemonitor #554

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

nevermarine
Copy link
Contributor

change scheme to https for prometheus to correctly collect metrics

Description

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

change scheme to https for prometheus to correctly collect metrics

Signed-off-by: Maksim Fedotov <[email protected]>
@nevermarine nevermarine marked this pull request as ready for review December 5, 2024 12:12
@yaroslavborbat yaroslavborbat merged commit 64effd2 into main Dec 5, 2024
13 checks passed
@yaroslavborbat yaroslavborbat deleted the fix/core/fix-scheme-for-cdi-servicemonitor branch December 5, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants