feat(api): console,vnc reconnect #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diafour
reviewed
Dec 5, 2024
images/virt-artifact/patches/024-stream-graceful-shutdown.patch
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniil Antoshin <[email protected]>
Signed-off-by: Daniil Antoshin <[email protected]>
Signed-off-by: Daniil Antoshin <[email protected]>
Signed-off-by: Daniil Antoshin <[email protected]>
Signed-off-by: Daniil Antoshin <[email protected]>
Signed-off-by: Daniil Antoshin <[email protected]>
danilrwx
force-pushed
the
feat/api/console-vnc-reconnect
branch
from
d590a89 to
6d18cc1
Compare
Signed-off-by: Daniil Antoshin <[email protected]>
yaroslavborbat
previously approved these changes
Dec 5, 2024
Signed-off-by: Daniil Antoshin <[email protected]>
yaroslavborbat
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Graceful termination of websocket connection for serial console and vnc connections
Why do we need it, and what problem does it solve?
Add the ability to handle connection termination if another user connects to the console or vnc
What is the expected result?
In case of connection of another user, send websocket connection closing message
Checklist