Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vi): update CEL #549

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix(vi): update CEL #549

merged 1 commit into from
Dec 3, 2024

Conversation

yaroslavborbat
Copy link
Member

@yaroslavborbat yaroslavborbat commented Dec 3, 2024

Description

update CEL for vi

Why do we need it, and what problem does it solve?

Fix creating vi with pvc, dataSource for vi wtih pvc doen't required

Error: 1 error occurred:
        * VirtualImage.virtualization.deckhouse.io "performance" is invalid: [spec.dataSource: Required value, <nil>: Invalid value: "null": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation]

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@yaroslavborbat yaroslavborbat added the validation/skip/doc_changes Skip doc changes validation label Dec 3, 2024
Signed-off-by: yaroslavborbat <[email protected]>
@yaroslavborbat yaroslavborbat requested review from danilrwx and Isteb4k and removed request for danilrwx December 3, 2024 12:49
@yaroslavborbat yaroslavborbat merged commit 98da864 into main Dec 3, 2024
12 checks passed
@yaroslavborbat yaroslavborbat deleted the fix/vi/update-cel branch December 3, 2024 12:54
universal-itengineer added a commit that referenced this pull request Dec 3, 2024
universal-itengineer added a commit that referenced this pull request Dec 3, 2024
Revert "fix(vi): update CEL (#549)"

This reverts commit 98da864.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation/skip/doc_changes Skip doc changes validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants