Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vm): add live migration for nodePlacement #518

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

yaroslavborbat
Copy link
Member

@yaroslavborbat yaroslavborbat commented Nov 12, 2024

Description

This feature will only be available in the EE edition!

Apply nodeSelector and Affinity configuration immediately to build EE.
Add patch 026-auto-migrate-if-nodeplacement-changed.patch for kubevirt.
By default, migration at kubevirt startup is performed only to puHotplug,memoryHotplug or update static volumes.
This patch startup live-migration after updating nodeSelector or affinity.
If the current node is matched to a new "nodeSelector" or "affinity", then the migration will not be started

Set cpu settings.
kubevirt mutates the vmi configuration if these values ​​are not set.
After which live migration may be unavailable due to collisions in the configuration.
Set cores
Set cpu sockets based on CPU requests
Set cpu MaxSockets based on CPU limits

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@yaroslavborbat yaroslavborbat added the validation/skip/copyright Skip copyright validation label Nov 12, 2024
@yaroslavborbat yaroslavborbat force-pushed the feat/vm/add-live-migrate-for-nodeplacement branch 3 times, most recently from 42ec5a0 to dde4eb7 Compare November 13, 2024 09:38
@yaroslavborbat yaroslavborbat force-pushed the feat/vm/add-live-migrate-for-nodeplacement branch 3 times, most recently from f2570ef to c75f196 Compare November 14, 2024 09:30
Taskfile.yaml Outdated Show resolved Hide resolved
Taskfile.yaml Outdated Show resolved Hide resolved
@yaroslavborbat yaroslavborbat force-pushed the feat/vm/add-live-migrate-for-nodeplacement branch 2 times, most recently from 2569091 to 334a95d Compare November 22, 2024 07:30
@yaroslavborbat yaroslavborbat force-pushed the feat/vm/add-live-migrate-for-nodeplacement branch 2 times, most recently from f0b6f8b to f20a02f Compare November 25, 2024 09:14
@yaroslavborbat yaroslavborbat added the edition/ce Use CE image for pull request workflows label Nov 27, 2024
@yaroslavborbat yaroslavborbat force-pushed the feat/vm/add-live-migrate-for-nodeplacement branch 2 times, most recently from ce047a7 to c4119ec Compare November 27, 2024 09:05
@universal-itengineer universal-itengineer added edition/ce Use CE image for pull request workflows and removed edition/ce Use CE image for pull request workflows labels Nov 27, 2024
@yaroslavborbat yaroslavborbat force-pushed the feat/vm/add-live-migrate-for-nodeplacement branch from c4119ec to 9318b08 Compare December 3, 2024 07:11
@hayer969 hayer969 removed the edition/ce Use CE image for pull request workflows label Dec 3, 2024
@yaroslavborbat yaroslavborbat force-pushed the feat/vm/add-live-migrate-for-nodeplacement branch from b8e2405 to a1821f9 Compare December 4, 2024 13:11
@yaroslavborbat yaroslavborbat force-pushed the feat/vm/add-live-migrate-for-nodeplacement branch from de3a4ab to 6bf319b Compare December 5, 2024 09:38
@hayer969 hayer969 added edition/ce Use CE image for pull request workflows and removed edition/ce Use CE image for pull request workflows labels Dec 5, 2024
@yaroslavborbat yaroslavborbat force-pushed the feat/vm/add-live-migrate-for-nodeplacement branch from 6bf319b to 46ef565 Compare December 5, 2024 13:47
@yaroslavborbat yaroslavborbat requested a review from fl64 December 5, 2024 13:50
yaroslavborbat and others added 20 commits December 9, 2024 10:50
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Co-authored-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Co-authored-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Co-authored-by: Nikita Korolev <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
@yaroslavborbat yaroslavborbat force-pushed the feat/vm/add-live-migrate-for-nodeplacement branch from 9643f9b to be41e39 Compare December 9, 2024 07:50
Signed-off-by: yaroslavborbat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation/skip/copyright Skip copyright validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants