-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vm): add live migration for nodePlacement #518
Open
yaroslavborbat
wants to merge
21
commits into
main
Choose a base branch
from
feat/vm/add-live-migrate-for-nodeplacement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaroslavborbat
force-pushed
the
feat/vm/add-live-migrate-for-nodeplacement
branch
3 times, most recently
from
November 13, 2024 09:38
42ec5a0
to
dde4eb7
Compare
yaroslavborbat
force-pushed
the
feat/vm/add-live-migrate-for-nodeplacement
branch
3 times, most recently
from
November 14, 2024 09:30
f2570ef
to
c75f196
Compare
diafour
reviewed
Nov 15, 2024
diafour
reviewed
Nov 15, 2024
diafour
reviewed
Nov 15, 2024
images/virt-artifact/patches/024-auto-migrate-if-nodeplacement-changed.patch
Outdated
Show resolved
Hide resolved
diafour
reviewed
Nov 15, 2024
diafour
reviewed
Nov 15, 2024
images/virtualization-artifact/pkg/controller/kvbuilder/kvvm.go
Outdated
Show resolved
Hide resolved
yaroslavborbat
force-pushed
the
feat/vm/add-live-migrate-for-nodeplacement
branch
2 times, most recently
from
November 22, 2024 07:30
2569091
to
334a95d
Compare
yaroslavborbat
force-pushed
the
feat/vm/add-live-migrate-for-nodeplacement
branch
2 times, most recently
from
November 25, 2024 09:14
f0b6f8b
to
f20a02f
Compare
yaroslavborbat
force-pushed
the
feat/vm/add-live-migrate-for-nodeplacement
branch
2 times, most recently
from
November 27, 2024 09:05
ce047a7
to
c4119ec
Compare
universal-itengineer
added
edition/ce
Use CE image for pull request workflows
and removed
edition/ce
Use CE image for pull request workflows
labels
Nov 27, 2024
yaroslavborbat
force-pushed
the
feat/vm/add-live-migrate-for-nodeplacement
branch
from
December 3, 2024 07:11
c4119ec
to
9318b08
Compare
yaroslavborbat
force-pushed
the
feat/vm/add-live-migrate-for-nodeplacement
branch
from
December 4, 2024 13:11
b8e2405
to
a1821f9
Compare
yaroslavborbat
force-pushed
the
feat/vm/add-live-migrate-for-nodeplacement
branch
from
December 5, 2024 09:38
de3a4ab
to
6bf319b
Compare
hayer969
added
edition/ce
Use CE image for pull request workflows
and removed
edition/ce
Use CE image for pull request workflows
labels
Dec 5, 2024
yaroslavborbat
force-pushed
the
feat/vm/add-live-migrate-for-nodeplacement
branch
from
December 5, 2024 13:47
6bf319b
to
46ef565
Compare
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Co-authored-by: Ivan Mikheykin <[email protected]> Signed-off-by: Yaroslav Borbat <[email protected]>
Co-authored-by: Ivan Mikheykin <[email protected]> Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Co-authored-by: Nikita Korolev <[email protected]> Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
yaroslavborbat
force-pushed
the
feat/vm/add-live-migrate-for-nodeplacement
branch
from
December 9, 2024 07:50
9643f9b
to
be41e39
Compare
Signed-off-by: yaroslavborbat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature will only be available in the EE edition!
Apply nodeSelector and Affinity configuration immediately to build EE.
Add patch
026-auto-migrate-if-nodeplacement-changed.patch
for kubevirt.By default, migration at kubevirt startup is performed only to puHotplug,memoryHotplug or update static volumes.
This patch startup live-migration after updating nodeSelector or affinity.
If the current node is matched to a new "nodeSelector" or "affinity", then the migration will not be started
Set cpu settings.
kubevirt mutates the vmi configuration if these values are not set.
After which live migration may be unavailable due to collisions in the configuration.
Set cores
Set cpu sockets based on CPU requests
Set cpu MaxSockets based on CPU limits
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist