refactor(cvi): use condition builder as condition api in cvi controller #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Isteb4k
requested changes
Nov 1, 2024
images/virtualization-artifact/pkg/controller/conditions/builder.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/cvi/internal/source/object_ref_vd.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/cvi/internal/source/sources.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/cvi/cvi_webhook.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/cvi/internal/source/http.go
Outdated
Show resolved
Hide resolved
universal-itengineer
force-pushed
the
main
branch
from
d444891 to
6e0c7e7
Compare
…ion-api Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
yaroslavborbat
requested changes
Nov 6, 2024
images/virtualization-artifact/pkg/controller/cvi/internal/datasource_ready.go
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/cvi/internal/datasource_ready.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/cvi/internal/datasource_ready.go
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/cvi/internal/source/http.go
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/cvi/internal/source/object_ref.go
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vi/internal/datasource_ready.go
Show resolved
Hide resolved
Isteb4k
requested changes
Nov 6, 2024
images/virtualization-artifact/pkg/controller/cvi/internal/source/http.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Isteb4k
requested changes
Nov 7, 2024
images/virtualization-artifact/pkg/controller/cvi/internal/life_cycle.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Valeriy Khorunzhin <[email protected]>
yaroslavborbat
previously approved these changes
Nov 7, 2024
Signed-off-by: Valeriy Khorunzhin <[email protected]>
added 3 commits
November 7, 2024 12:28
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Isteb4k
approved these changes
Nov 7, 2024
Signed-off-by: Valeriy Khorunzhin <[email protected]>
eofff
force-pushed
the
refactor/cvi/use-condition-builder-as-condition-api
branch
from
b101785 to
549feed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use condition builder as condition api in cvi controller.
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist