feat(api): improve crd conditions #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaroslavborbat
force-pushed
the
feat/api/crds-conditions
branch
from
2ac5d98 to
39145ac
Compare
fl64
reviewed
Oct 31, 2024
yaroslavborbat
removed
the
validation/skip/doc_changes
yaroslavborbat
force-pushed
the
feat/api/crds-conditions
branch
from
344c9ef to
101a4b0
Compare
Isteb4k
previously approved these changes
Nov 1, 2024
Isteb4k
previously approved these changes
Nov 2, 2024
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
yaroslavborbat
force-pushed
the
feat/api/crds-conditions
branch
from
ff5d0e8 to
c1a1111
Compare
Isteb4k
approved these changes
Nov 5, 2024
danilrwx
pushed a commit
that referenced
this pull request
Nov 5, 2024
Make all crds have the same conditions --------- Signed-off-by: yaroslavborbat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make all crds have the same conditions
Why do we need it, and what problem does it solve?
We have different specifications of conditions.
There is no validation of conditions in crds.
What is the expected result?
Checklist