feat(vmclass): improve vmclass #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaroslavborbat
force-pushed
the
feat/vmclass/add-features
branch
from
6fd5c43 to
b5c0233
Compare
yaroslavborbat
force-pushed
the
feat/vmclass/add-features
branch
from
b5c0233 to
779d67f
Compare
diafour
reviewed
Oct 29, 2024
diafour
reviewed
Oct 29, 2024
images/virtualization-artifact/pkg/controller/vmclass/internal/state/state.go
Outdated
Show resolved
Hide resolved
yaroslavborbat
force-pushed
the
feat/vmclass/add-features
branch
4 times, most recently
from
fbb16d6 to
ba17f4c
Compare
diafour
reviewed
Oct 30, 2024
diafour
reviewed
Oct 30, 2024
images/virtualization-artifact/pkg/controller/vmclass/internal/state/state.go
Outdated
Show resolved
Hide resolved
yaroslavborbat
force-pushed
the
feat/vmclass/add-features
branch
from
8c68e05 to
2f705b1
Compare
freeze features Signed-off-by: yaroslavborbat <[email protected]>
add tolerations --------- Signed-off-by: yaroslavborbat <[email protected]> Co-authored-by: Ivan Mikheykin <[email protected]> Signed-off-by: yaroslavborbat <[email protected]>
generate available nodes with nodeSelector Signed-off-by: yaroslavborbat <[email protected]>
immutable .spec.cpu Signed-off-by: yaroslavborbat <[email protected]>
Co-authored-by: Ivan Mikheykin <[email protected]> Signed-off-by: Yaroslav Borbat <[email protected]> Signed-off-by: yaroslavborbat <[email protected]>
add max allocatable resources --------- Signed-off-by: yaroslavborbat <[email protected]>
Co-authored-by: Ivan Mikheykin <[email protected]> Signed-off-by: Yaroslav Borbat <[email protected]>
…/state/state.go Co-authored-by: Ivan Mikheykin <[email protected]> Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
yaroslavborbat
force-pushed
the
feat/vmclass/add-features
branch
from
d68084a to
d587682
Compare
diafour
approved these changes
Nov 2, 2024
danilrwx
pushed a commit
that referenced
this pull request
Nov 5, 2024
Add vmclass features: - freeze features after first discovery - add tolerations - generate available nodes with nodeSelector - immutable .spec.cpu - add maxAllocatableResources --------- Signed-off-by: yaroslavborbat <[email protected]> Co-authored-by: Ivan Mikheykin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add features:
What is the expected result?
Checklist