feat(vi,vd): add custom settings for SC #437
Merged
+1,092
−341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diafour
reviewed
Oct 15, 2024
LopatinDmitr
force-pushed
the
feat/vi/vd/add-custom-settings-for-storage-classes
branch
from
8d85081 to
0dfe76f
Compare
LopatinDmitr
force-pushed
the
feat/vi/vd/add-custom-settings-for-storage-classes
branch
4 times, most recently
from
02deb18 to
c8c5988
Compare
diafour
reviewed
Oct 28, 2024
diafour
reviewed
Oct 28, 2024
images/virtualization-artifact/pkg/controller/dvcr_data_source.go
Outdated
Show resolved
Hide resolved
diafour
reviewed
Oct 28, 2024
images/virtualization-artifact/pkg/config/load_vi_storage_class_settings.go
Show resolved
Hide resolved
diafour
reviewed
Oct 28, 2024
images/virtualization-artifact/pkg/controller/vd/internal/source/sources.go
Outdated
Show resolved
Hide resolved
diafour
reviewed
Oct 28, 2024
diafour
reviewed
Oct 28, 2024
diafour
reviewed
Oct 28, 2024
LopatinDmitr
force-pushed
the
feat/vi/vd/add-custom-settings-for-storage-classes
branch
7 times, most recently
from
8f92b35 to
08a6881
Compare
LopatinDmitr
force-pushed
the
feat/vi/vd/add-custom-settings-for-storage-classes
branch
from
08a6881 to
2625dc7
Compare
diafour
reviewed
Nov 5, 2024
images/virtualization-artifact/pkg/controller/service/vd_storage_class_service.go
Outdated
Show resolved
Hide resolved
diafour
reviewed
Nov 5, 2024
universal-itengineer
force-pushed
the
main
branch
from
d444891 to
6e0c7e7
Compare
LopatinDmitr
force-pushed
the
feat/vi/vd/add-custom-settings-for-storage-classes
branch
3 times, most recently
from
4cf037d to
8876949
Compare
diafour
previously approved these changes
Nov 15, 2024
LopatinDmitr
force-pushed
the
feat/vi/vd/add-custom-settings-for-storage-classes
branch
12 times, most recently
from
4f25f0b to
4539149
Compare
Signed-off-by: dmitry.lopatin <[email protected]>
LopatinDmitr
force-pushed
the
feat/vi/vd/add-custom-settings-for-storage-classes
branch
from
4539149 to
adc8256
Compare
diafour
approved these changes
Nov 19, 2024
LopatinDmitr
deleted the
feat/vi/vd/add-custom-settings-for-storage-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update introduces customizable settings in module
Virtualizationfor managing storage classes related toVirtualImagesandVirtualDisks. The new feature allows for specifying allowed and default storage class names for bothVirtualImagesandVirtualDisks.Why do we need it, and what problem does it solve?
What is the expected result?
Checklist