fix(cvi,vi): unlock pending vi/cvi from vd ref

api/core/v1alpha2/cvicondition/condition.go

@@ -56,6 +56,8 @@ const (
 	ClusterImageNotReady DatasourceReadyReason = "ClusterImageNotReady"
 	// VirtualDiskNotReady indicates that the `VirtualDisk` datasource is not ready, which prevents the import process from starting.
 	VirtualDiskNotReady DatasourceReadyReason = "VirtualDiskNotReady"
+	// VirtualDiskInUseInRunningVirtualMachine indicates that the `VirtualDisk` attached to running `VirtualMachine`
+	VirtualDiskInUseInRunningVirtualMachine DatasourceReadyReason = "VirtualDiskInUseInRunningVirtualMachine"
 
 	// WaitForUserUpload indicates that the `ClusterVirtualImage` is waiting for the user to upload a datasource for the import process to continue.
 	WaitForUserUpload ReadyReason = "WaitForUserUpload"

api/core/v1alpha2/vdcondition/condition.go

@@ -34,6 +34,8 @@ const (
 	SnapshottingType Type = "Snapshotting"
 	// StorageClassReadyType indicates whether the storage class is ready.
 	StorageClassReadyType Type = "StorageClassReady"
+	// InUseType indicates whether the VirtualDisk is attached to a running VirtualMachine or is being used in a process of a VirtualImage creation.
+	InUseType Type = "InUse"
 )
 
 type (
@@ -47,6 +49,8 @@ type (
 	SnapshottingReason string
 	// StorageClassReadyReason represents the various reasons for the Storageclass ready condition type.
 	StorageClassReadyReason string
+	// InUseReason represents the various reasons for the InUse condition type.
+	InUseReason string
 )
 
 func (s DatasourceReadyReason) String() string {
@@ -69,6 +73,10 @@ func (s StorageClassReadyReason) String() string {
 	return string(s)
 }
 
+func (s InUseReason) String() string {
+	return string(s)
+}
+
 const (
 	// DatasourceReady indicates that the datasource is ready for use, allowing the import process to start.
 	DatasourceReady DatasourceReadyReason = "DatasourceReady"
@@ -118,4 +126,9 @@ const (
 	StorageClassReady StorageClassReadyReason = "StorageClassReady"
 	// StorageClassNotFound indicates that the storage class is not ready
 	StorageClassNotFound StorageClassReadyReason = "StorageClassNotFound"
+
+	// AllowedForImageUsage indicates that the VirtualDisk is permitted for use in a process of an image creation.
+	AllowedForImageUsage InUseReason = "AllowedForImageUsage"
+	// AllowedForVirtualMachineUsage indicates that the VirtualDisk is permitted for use by a running VirtualMachine.
+	AllowedForVirtualMachineUsage InUseReason = "AllowedForVirtualMachineUsage"
 )

api/core/v1alpha2/vicondition/condition.go

@@ -64,6 +64,8 @@ const (
 	ClusterImageNotReady DatasourceReadyReason = "ClusterImageNotReady"
 	// VirtualDiskNotReady indicates that the `VirtualDisk` datasource is not ready, which prevents the import process from starting.
 	VirtualDiskNotReady DatasourceReadyReason = "VirtualDiskNotReady"
+	// VirtualDiskInUseInRunningVirtualMachine indicates that the `VirtualDisk` attached to running `VirtualMachine`
+	VirtualDiskInUseInRunningVirtualMachine DatasourceReadyReason = "VirtualDiskInUseInRunningVirtualMachine"
 
 	// WaitForUserUpload indicates that the `VirtualImage` is waiting for the user to upload a datasource for the import process to continue.
 	WaitForUserUpload ReadyReason = "WaitForUserUpload"

images/virtualization-artifact/pkg/controller/cvi/cvi_reconciler.go

@@ -34,10 +34,12 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/reconcile"
 	"sigs.k8s.io/controller-runtime/pkg/source"
 
+	"github.com/deckhouse/virtualization-controller/pkg/controller/conditions"
 	"github.com/deckhouse/virtualization-controller/pkg/controller/service"
 	"github.com/deckhouse/virtualization-controller/pkg/controller/watchers"
 	"github.com/deckhouse/virtualization-controller/pkg/logger"
 	virtv2 "github.com/deckhouse/virtualization/api/core/v1alpha2"
+	"github.com/deckhouse/virtualization/api/core/v1alpha2/vdcondition"
 )
 
 type Handler interface {
@@ -165,7 +167,14 @@ func (r *Reconciler) SetupController(_ context.Context, mgr manager.Manager, ctr
 					return false
 				}
 
-				return oldVD.Status.Phase != newVD.Status.Phase
+				oldInUseCondition, _ := conditions.GetCondition(vdcondition.InUseType, oldVD.Status.Conditions)
+				newInUseCondition, _ := conditions.GetCondition(vdcondition.InUseType, newVD.Status.Conditions)
+
+				if oldVD.Status.Phase != newVD.Status.Phase || len(oldVD.Status.AttachedToVirtualMachines) != len(newVD.Status.AttachedToVirtualMachines) || oldInUseCondition.Status != newInUseCondition.Status {
+					return true
+				}
+
+				return false
 			},
 		},
 	); err != nil {

images/virtualization-artifact/pkg/controller/cvi/internal/datasource_ready.go

@@ -89,10 +89,10 @@ func (h DatasourceReadyHandler) Handle(ctx context.Context, cvi *virtv2.ClusterV
 			Reason(cvicondition.VirtualDiskNotReady).
 			Message(service.CapitalizeFirstLetter(err.Error()))
 		return reconcile.Result{}, nil
-	case errors.As(err, &source.VirtualDiskAttachedToRunningVMError{}):
+	case errors.As(err, &source.VirtualDiskNotAllowedForUseError{}):
 		cb.
 			Status(metav1.ConditionFalse).
-			Reason(cvicondition.VirtualDiskNotReady).
+			Reason(cvicondition.VirtualDiskInUseInRunningVirtualMachine).
 			Message(service.CapitalizeFirstLetter(err.Error()))
 		return reconcile.Result{}, nil
 	default:

images/virtualization-artifact/pkg/controller/cvi/internal/source/errors.go

@@ -65,18 +65,16 @@ func NewVirtualDiskNotReadyError(name string) error {
 	}
 }
 
-type VirtualDiskAttachedToRunningVMError struct {
-	name   string
-	vmName string
+type VirtualDiskNotAllowedForUseError struct {
+	name string
 }
 
-func (e VirtualDiskAttachedToRunningVMError) Error() string {
-	return fmt.Sprintf("VirtualDisk %q attached to running VirtualMachine %q", e.name, e.vmName)
+func (e VirtualDiskNotAllowedForUseError) Error() string {
+	return fmt.Sprintf("use of VirtualDisk %s is not allowed, it may be connected to a running VirtualMachine", e.name)
 }
 
-func NewVirtualDiskAttachedToRunningVMError(name, vmName string) error {
-	return VirtualDiskAttachedToRunningVMError{
-		name:   name,
-		vmName: vmName,
+func NewVirtualDiskNotAllowedForUseError(name string) error {
+	return VirtualDiskNotAllowedForUseError{
+		name: name,
 	}
 }

images/virtualization-artifact/pkg/controller/cvi/internal/source/object_ref_vd.go

@@ -39,6 +39,7 @@ import (
 	"github.com/deckhouse/virtualization-controller/pkg/logger"
 	virtv2 "github.com/deckhouse/virtualization/api/core/v1alpha2"
 	"github.com/deckhouse/virtualization/api/core/v1alpha2/cvicondition"
+	"github.com/deckhouse/virtualization/api/core/v1alpha2/vdcondition"
 )
 
 type ObjectRefVirtualDisk struct {
@@ -226,18 +227,10 @@ func (ds ObjectRefVirtualDisk) Validate(ctx context.Context, cvi *virtv2.Cluster
 		return NewVirtualDiskNotReadyError(cvi.Spec.DataSource.ObjectRef.Name)
 	}
 
-	if len(vd.Status.AttachedToVirtualMachines) != 0 {
-		vmName := vd.Status.AttachedToVirtualMachines[0]
-
-		vm, err := object.FetchObject(ctx, types.NamespacedName{Name: vmName.Name, Namespace: vd.Namespace}, ds.client, &virtv2.VirtualMachine{})
-		if err != nil {
-			return err
-		}
-
-		if vm.Status.Phase != virtv2.MachineStopped {
-			return NewVirtualDiskAttachedToRunningVMError(vd.Name, vmName.Name)
-		}
+	inUseCondition, _ := conditions.GetCondition(vdcondition.InUseType, vd.Status.Conditions)
+	if inUseCondition.Status == metav1.ConditionTrue && inUseCondition.Reason == vdcondition.AllowedForImageUsage.String() {
+		return nil
 	}
 
-	return nil
+	return NewVirtualDiskNotAllowedForUseError(vd.Name)
 }

images/virtualization-artifact/pkg/controller/service/errors.go

@@ -16,7 +16,10 @@ limitations under the License.
 
 package service
 
-import "errors"
+import (
+	"errors"
+	"fmt"
+)
 
 var (
 	ErrStorageClassNotFound        = errors.New("storage class not found")
@@ -30,3 +33,31 @@ var (
 	ErrIPAddressAlreadyExist = errors.New("the IP address is already allocated")
 	ErrIPAddressOutOfRange   = errors.New("the IP address is out of range")
 )
+
+type VirtualDiskUsedByImageError struct {
+	vdName string
+}
+
+func (e VirtualDiskUsedByImageError) Error() string {
+	return fmt.Sprintf("the virtual disk %q already used by creating image", e.vdName)
+}
+
+func NewVirtualDiskUsedByImageError(name string) error {
+	return VirtualDiskUsedByImageError{
+		vdName: name,
+	}
+}
+
+type VirtualDiskUsedByVirtualMachineError struct {
+	vdName string
+}
+
+func (e VirtualDiskUsedByVirtualMachineError) Error() string {
+	return fmt.Sprintf("the virtual disk %q already used by running virtual machine", e.vdName)
+}
+
+func NewVirtualDiskUsedByVirtualMachineError(name string) error {
+	return VirtualDiskUsedByVirtualMachineError{
+		vdName: name,
+	}
+}