Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vmbda): write to condition message if disk is already attached to vm spec #267

Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix(vmbda): write to condition message if disk is already attached to vm spec #267

merged 1 commit into from
Aug 15, 2024

Conversation

Isteb4k
Copy link
Contributor

@Isteb4k Isteb4k commented Aug 9, 2024 •
edited
Loading

Description

  1. For vmbda, added a message to the condition that indicates a disk conflict if disk is already added to the virtual machine spec
  2. Fixed an issue that prevented adding a disk to the spec when the vmbda with that disk was deleted for the virtual machine.
  3. Failed phase is no longer final for vmbda (it can transition to Pending).
  4. New validator for VM: BlockDeviceSpecRefsValidator, which prevents duplicate spec.BlockDeviceRef entries.
  5. VM validators have been moved to internal/validators.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@Isteb4k Isteb4k force-pushed the fix/vmbda/disk-already-attached branch 2 times, most recently from bbd83ba to 678789c Compare August 9, 2024 11:47
@Isteb4k Isteb4k changed the base branch from main to feat/api/importer-req-lim August 9, 2024 11:56
@Isteb4k Isteb4k changed the title Fix/vmbda/disk already attached fix(vmbda): write to condition message if disk is already attaced to vm spec Aug 9, 2024
@Isteb4k Isteb4k force-pushed the fix/vmbda/disk-already-attached branch from fb5dd27 to 1897469 Compare August 9, 2024 12:47
Base automatically changed from feat/api/importer-req-lim to main August 9, 2024 12:52
@Isteb4k Isteb4k force-pushed the fix/vmbda/disk-already-attached branch 2 times, most recently from b7dbf77 to cfae49c Compare August 9, 2024 12:53
@Isteb4k Isteb4k marked this pull request as ready for review August 9, 2024 14:02
@Isteb4k Isteb4k force-pushed the fix/vmbda/disk-already-attached branch from cfae49c to 4717a55 Compare August 9, 2024 14:17
@universal-itengineer universal-itengineer changed the title fix(vmbda): write to condition message if disk is already attaced to vm spec fix(vmbda): write to condition message if disk is already attached to vm spec Aug 12, 2024
@Isteb4k Isteb4k force-pushed the fix/vmbda/disk-already-attached branch from 4717a55 to da6768b Compare August 13, 2024 21:27
@Isteb4k Isteb4k force-pushed the fix/vmbda/disk-already-attached branch from da6768b to 4032934 Compare August 14, 2024 16:20
@Isteb4k Isteb4k force-pushed the fix/vmbda/disk-already-attached branch from 4032934 to dff304a Compare August 14, 2024 16:21
@Isteb4k Isteb4k merged commit 8b5551d into main Aug 15, 2024
10 checks passed
@Isteb4k Isteb4k deleted the fix/vmbda/disk-already-attached branch August 15, 2024 08:39
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Aug 15, 2024
Merged
universal-itengineer pushed a commit that referenced this pull request Aug 22, 2024
@deckhouse-BOaTswain
chore(main): release 0.12.3 (#288)
c5a7b9a 
Bug Fixes:
provisioner: fix provisioner pods buffer issue (#302) (e332b64)
vd,vmbda: write occurred data volume errors to condition (4694b5e)
vd: write error to condition if pvc size is smaller than virtual size of source image (de61f96)
vd: write size error to condition (de61f96)
vm: added processing of an empty phase for a VM and KVVM (#274) (683bb70)
vmbda: write to condition message if disk is already attached to vm spec (#267) (8b5551d)
vmclass: add missing nodeSelector for discovery type (#293) (1a461a4)
vmip: fix bug of creating two VirtualMachineIPAddress with the same name in different namespaces (#287) (af7dd97)
vmip: fix bug with create VirtualMachineIPAddress in different namespace, when VirtualMahineIPAddressLease 'Released' (#296) (4425e79)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LopatinDmitr LopatinDmitr LopatinDmitr approved these changes

@yaroslavborbat yaroslavborbat Awaiting requested review from yaroslavborbat

Assignees

@Isteb4k Isteb4k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isteb4k @LopatinDmitr