feat(vmip): validate IP address range and improve IP address service #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LopatinDmitr
force-pushed
the
feat/vmip/add-validating-ip-address
branch
from
8273481 to
f86f4f8
Compare
LopatinDmitr
force-pushed
the
feat/vmip/add-validating-ip-address
branch
from
f86f4f8 to
633f447
Compare
LopatinDmitr
force-pushed
the
feat/vmip/apply-new-design
branch
from
c980d23 to
b73a1e2
Compare
LopatinDmitr
force-pushed
the
feat/vmip/add-validating-ip-address
branch
3 times, most recently
from
281c00f to
26e10cc
Compare
Isteb4k
requested changes
Jul 25, 2024
images/virtualization-artifact/pkg/controller/service/errors.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/ip_address_service.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/errors.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/errors.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/ip_address_service.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/ip_address_service.go
Outdated
Show resolved
Hide resolved
LopatinDmitr
force-pushed
the
feat/vmip/add-validating-ip-address
branch
3 times, most recently
from
6c914d5 to
8b85d82
Compare
diafour
reviewed
Jul 26, 2024
images/virtualization-artifact/pkg/controller/service/ip_address_service.go
Outdated
Show resolved
Hide resolved
diafour
reviewed
Jul 29, 2024
images/virtualization-artifact/pkg/controller/vmip/internal/iplease_handler.go
Outdated
Show resolved
Hide resolved
diafour
reviewed
Jul 29, 2024
images/virtualization-artifact/pkg/controller/service/ip_address_service.go
Show resolved
Hide resolved
LopatinDmitr
force-pushed
the
feat/vmip/add-validating-ip-address
branch
2 times, most recently
from
bf8d7d9 to
d81492c
Compare
- Add checking the ip address for compliance with the specified in the CIDR module settings - The operation of the controller has been redesigned from using of net.IPNet to netip.Addr Signed-off-by: Dmitry Lopatin <[email protected]>
LopatinDmitr
force-pushed
the
feat/vmip/add-validating-ip-address
branch
from
d81492c to
3d69061
Compare
- Fix frequent reconciles for an object with the 'Released' status - Add write to events, when the selected VirtualMachineIPLease belongs to a different namespace Signed-off-by: Dmitry Lopatin <[email protected]>
Signed-off-by: Dmitry Lopatin <[email protected]>
LopatinDmitr
force-pushed
the
feat/vmip/add-validating-ip-address
branch
from
3d69061 to
41968e9
Compare
Isteb4k
approved these changes
Jul 30, 2024
LopatinDmitr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist