Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vm): fix vm-router panics when we delete a virtual machine. #201

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

yaroslavborbat
Copy link
Member

Description

fix reconsile VM. refactor DeleteRoute.

Why do we need it, and what problem does it solve?

vm-router panics when we delete a virtual machine.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
images/vmi-router/controllers/vmirouter_reconciler.go Outdated Show resolved Hide resolved
images/vmi-router/controllers/vmirouter_reconciler.go Outdated Show resolved Hide resolved
images/vmi-router/netlinkmanager/manager.go Outdated Show resolved Hide resolved
Signed-off-by: yaroslavborbat <[email protected]>
@yaroslavborbat yaroslavborbat requested a review from Isteb4k July 10, 2024 09:55
@yaroslavborbat yaroslavborbat merged commit 8ebce8c into main Jul 11, 2024
1 check passed
@yaroslavborbat yaroslavborbat deleted the fix/router/panic-if-vm-not-found branch July 11, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants