Skip to content

Commit

Permalink
fix(vd): add new handler
Browse files Browse the repository at this point in the history
Signed-off-by: dmitry.lopatin <[email protected]>
  • Loading branch information
LopatinDmitr committed Nov 26, 2024
1 parent b19bd2b commit 8b0c8b6
Show file tree
Hide file tree
Showing 9 changed files with 783 additions and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,8 @@ func (ds ObjectRefVirtualDisk) Validate(ctx context.Context, cvi *virtv2.Cluster
}

inUseCondition, _ := conditions.GetCondition(vdcondition.InUseType, vd.Status.Conditions)
if inUseCondition.Status == metav1.ConditionTrue {
if inUseCondition.Reason == vdcondition.AllowedForImageUsage.String() {
return nil
}
if inUseCondition.Status == metav1.ConditionTrue && inUseCondition.Reason == vdcondition.AllowedForImageUsage.String() {
return nil
}

return NewVirtualDiskNotAllowedForUseError(vd.Name)
Expand Down
180 changes: 180 additions & 0 deletions images/virtualization-artifact/pkg/controller/vd/internal/inuse.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,180 @@
/*
Copyright 2024 Flant JSC
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package internal

import (
"context"
"fmt"
"slices"

metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
virtv1 "kubevirt.io/api/core/v1"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/reconcile"

"github.com/deckhouse/virtualization-controller/pkg/controller/conditions"
"github.com/deckhouse/virtualization-controller/pkg/sdk/framework/helper"
virtv2 "github.com/deckhouse/virtualization/api/core/v1alpha2"
"github.com/deckhouse/virtualization/api/core/v1alpha2/vdcondition"
"github.com/deckhouse/virtualization/api/core/v1alpha2/vmcondition"
)

type InUseHandler struct {
client client.Client
}

func NewInUseHandler(client client.Client) *InUseHandler {
return &InUseHandler{
client: client,
}
}

func (h InUseHandler) Handle(ctx context.Context, vd *virtv2.VirtualDisk) (reconcile.Result, error) {
inUseCondition, ok := conditions.GetCondition(vdcondition.InUseType, vd.Status.Conditions)
if !ok {
cb := conditions.NewConditionBuilder(vdcondition.InUseType).
Status(metav1.ConditionUnknown).
Reason(conditions.ReasonUnknown).
Generation(vd.Generation)
conditions.SetCondition(cb, &vd.Status.Conditions)
inUseCondition = cb.Condition()
}

allowUseForVM, allowUseForImage := false, false

var vms virtv2.VirtualMachineList
err := h.client.List(ctx, &vms, &client.ListOptions{
Namespace: vd.GetNamespace(),
})
if err != nil {
return reconcile.Result{}, fmt.Errorf("error getting virtual machines: %w", err)
}

for _, vm := range vms.Items {
if h.isVDAttachedToVM(vd.GetName(), vm) {
if vm.Status.Phase != virtv2.MachineStopped {
allowUseForVM = isVMReady(vm.Status.Conditions)

if allowUseForVM {
break
}
} else {
kvvm, err := helper.FetchObject(ctx, types.NamespacedName{Name: vm.Name, Namespace: vm.Namespace}, h.client, &virtv1.VirtualMachine{})
if err != nil {
return reconcile.Result{}, fmt.Errorf("error getting kvvms: %w", err)
}

if kvvm != nil && kvvm.Status.StateChangeRequests != nil {
allowUseForVM = true
break
}
}
}
}

var vis virtv2.VirtualImageList
err = h.client.List(ctx, &vis, &client.ListOptions{
Namespace: vd.GetNamespace(),
})
if err != nil {
return reconcile.Result{}, fmt.Errorf("error getting virtual images: %w", err)
}

allowedPhases := []virtv2.ImagePhase{virtv2.ImageProvisioning, virtv2.ImagePending}

for _, vi := range vis.Items {
if slices.Contains(allowedPhases, vi.Status.Phase) && vi.Spec.DataSource.Type == virtv2.DataSourceTypeObjectRef && vi.Spec.DataSource.ObjectRef != nil && vi.Spec.DataSource.ObjectRef.Kind == virtv2.VirtualDiskKind {
allowUseForImage = true
break
}
}

var cvis virtv2.ClusterVirtualImageList
err = h.client.List(ctx, &cvis, &client.ListOptions{})
if err != nil {
return reconcile.Result{}, fmt.Errorf("error getting cluster virtual images: %w", err)
}
for _, cvi := range cvis.Items {
if slices.Contains(allowedPhases, cvi.Status.Phase) && cvi.Spec.DataSource.Type == virtv2.DataSourceTypeObjectRef && cvi.Spec.DataSource.ObjectRef != nil && cvi.Spec.DataSource.ObjectRef.Kind == virtv2.VirtualDiskKind {
allowUseForImage = true
}
}

cb := conditions.NewConditionBuilder(vdcondition.InUseType)

switch {
case allowUseForVM && inUseCondition.Status == metav1.ConditionUnknown:
if inUseCondition.Reason != vdcondition.AllowedForVirtualMachineUsage.String() {
cb.
Generation(vd.Generation).
Status(metav1.ConditionTrue).
Reason(vdcondition.AllowedForVirtualMachineUsage).
Message("")
conditions.SetCondition(cb, &vd.Status.Conditions)
}
case allowUseForImage && inUseCondition.Status == metav1.ConditionUnknown:
if inUseCondition.Reason != vdcondition.AllowedForImageUsage.String() {
cb.
Generation(vd.Generation).
Status(metav1.ConditionTrue).
Reason(vdcondition.AllowedForImageUsage).
Message("")
conditions.SetCondition(cb, &vd.Status.Conditions)
}
default:
if inUseCondition.Reason == vdcondition.AllowedForVirtualMachineUsage.String() && !allowUseForVM || inUseCondition.Reason == vdcondition.AllowedForImageUsage.String() && !allowUseForImage {
cb.
Generation(vd.Generation).
Status(metav1.ConditionUnknown).
Reason(conditions.ReasonUnknown).
Message("")
conditions.SetCondition(cb, &vd.Status.Conditions)
}

if allowUseForImage || allowUseForVM {
return reconcile.Result{Requeue: true}, nil
}
}

return reconcile.Result{}, nil
}

func (h InUseHandler) isVDAttachedToVM(vdName string, vm virtv2.VirtualMachine) bool {
for _, bda := range vm.Status.BlockDeviceRefs {
if bda.Kind == virtv2.DiskDevice && bda.Name == vdName {
return true
}
}

return false
}

func isVMReady(conditions []metav1.Condition) bool {
critConditions := []string{
vmcondition.TypeIPAddressReady.String(),
vmcondition.TypeClassReady.String(),
}

for _, c := range conditions {
if slices.Contains(critConditions, c.Type) && c.Status == metav1.ConditionFalse {
return false
}
}

return true
}
Loading

0 comments on commit 8b0c8b6

Please sign in to comment.