Apply suggestions from code review

Signed-off-by: Ivan Mikheykin <[email protected]>
deckhouse · Nov 1, 2024 · 55db7c6 · 55db7c6
1 parent 298855f
commit 55db7c6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/tests/e2e/ginkgoutil/decorators.go b/tests/e2e/ginkgoutil/decorators.go
@@ -47,9 +47,9 @@ func DecoratorsFromEnv(decorators ...interface{}) []interface{} {
 	out := make([]interface{}, 0)
 
 	for _, decorator := range decorators {
-		switch decorator.(type) {
+		switch v := decorator.(type) {
 		case EnvSwitchable:
-			gdeco := decorator.(EnvSwitchable).Decorator()
+			gdeco := v.Decorator()
 			if gdeco != nil {
 				out = append(out, gdeco)
 			}

diff --git a/tests/e2e/tests_suite_test.go b/tests/e2e/tests_suite_test.go
@@ -112,7 +112,7 @@ func TestTests(t *testing.T) {
 	RegisterFailHandler(Fail)
 	fmt.Fprintf(GinkgoWriter, "Starting test suite\n")
 	RunSpecs(t, "Tests")
-	if (ginkgoutil.FailureBehaviourEnvSwitcher{}).IsStopOnFailure() {
+	if !(ginkgoutil.FailureBehaviourEnvSwitcher{}).IsStopOnFailure() {
 		Cleanup()
 	}
 }