Add option to force image check for disabled/suspended workloads #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zuzzas, can you please review this PR? |
|
One more thing I noticed by looking through the repo. |
verdel
force-pushed
the
force-image-check-disable-workloads
branch
2 times, most recently
from
f35a162
to
019c9d2
Compare
Signed-off-by: Vadim Aleksandrov <[email protected]>
verdel
force-pushed
the
force-image-check-disable-workloads
branch
from
019c9d2
to
de013d0
Compare
|
@nabokihms, I have made the requested changes and also added a description of the option in README.md. If you have the opportunity, I would appreciate it if you could review the pull request again. |
nabokihms
requested changes
Jan 12, 2024
Signed-off-by: Vadim Aleksandrov <[email protected]>
Thank you very much for your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the exporter does not check the availability of docker image for disable/suspend workloads. I add a CLI option
check-disabledthat will bypass the workloadenablestatus check. This force docker image check for disabled/suspended workloads.Option
check-disabledequalfalseby default to avoid creating breaking changes.Closes #74