Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: etcd backup #46

Merged
merged 1 commit into from
Oct 9, 2024
Merged

feature: etcd backup #46

merged 1 commit into from
Oct 9, 2024

Conversation

mvasl
Copy link
Member

@mvasl mvasl commented Oct 3, 2024

Added a backup family of subcommands. As of now, it can only backup etcd state.(deckhouse/deckhouse#9948 is required to support that)

Usage docs: deckhouse/deckhouse#10014

@mvasl mvasl self-assigned this Oct 3, 2024
@mvasl mvasl force-pushed the feature/etcd-backup branch 3 times, most recently from edf0193 to 94cc8e8 Compare October 7, 2024 08:12
@mvasl mvasl requested a review from sprait October 7, 2024 08:13
@mvasl mvasl marked this pull request as ready for review October 7, 2024 08:13
@mvasl mvasl force-pushed the feature/etcd-backup branch 2 times, most recently from 17b132a to 4f0aeca Compare October 7, 2024 08:21
@mvasl
Copy link
Member Author

mvasl commented Oct 7, 2024

image

Copy link
Member

@sprait sprait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

internal/backup/cmd/etcd/etcd.go Show resolved Hide resolved
internal/backup/cmd/etcd/flags.go Outdated Show resolved Hide resolved
internal/backup/cmd/etcd/etcd.go Show resolved Hide resolved
@mvasl mvasl force-pushed the feature/etcd-backup branch from 08ae65c to a613676 Compare October 9, 2024 10:36
@mvasl mvasl requested a review from sprait October 9, 2024 10:37
@mvasl mvasl force-pushed the feature/etcd-backup branch 2 times, most recently from ac4525f to 756bca1 Compare October 9, 2024 10:53
Signed-off-by: Maxim Vasilenko <[email protected]>
@mvasl mvasl force-pushed the feature/etcd-backup branch from 756bca1 to 24641eb Compare October 9, 2024 11:09
@mvasl mvasl merged commit 7bad692 into main Oct 9, 2024
2 checks passed
@mvasl mvasl deleted the feature/etcd-backup branch October 9, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants