-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[controller] Add NFSStorageClass controller and validation webhook for StorageClasses with provisioner nfs.csi.k8s.io #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksZimin
changed the title
[controller] add controller
[controller] Add NFSStorageClass controller and validation webhook for StorageClasses with provisioner nfs.csi.k8s.io
May 7, 2024
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
AleksZimin
force-pushed
the
add-nfs-sc-controller
branch
from
May 8, 2024 10:00
98781fe
to
72e4fdd
Compare
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
dxavx
approved these changes
May 8, 2024
AleksZimin
force-pushed
the
add-nfs-sc-controller
branch
2 times, most recently
from
May 13, 2024 07:18
8f538a6
to
0ed39d6
Compare
AleksZimin
force-pushed
the
add-nfs-sc-controller
branch
2 times, most recently
from
May 13, 2024 12:56
c1f1742
to
796bea4
Compare
Signed-off-by: Aleksandr Zimin <[email protected]>
AleksZimin
force-pushed
the
add-nfs-sc-controller
branch
from
May 13, 2024 12:58
796bea4
to
1b28035
Compare
dxavx
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
NFSStorageClass
controller along with a validation webhook for StorageClasses that utilize thenfs.csi.k8s.io
provisioner. The new controller is responsible for managing NFS-based StorageClasses, ensuring streamlined lifecycle management. The accompanying validation webhook is designed to enforce strict control over these StorageClasses, prohibiting any direct modifications, creations, or deletions. All changes to NFS StorageClasses must be made through theNFSStorageClass
resource, ensuring compliance with defined standards and configurations.Why do we need it, and what problem does it solve?
NFSStorageClass
controller automates the management of NFS-based StorageClasses, ensuring that they are handled consistently. This automation simplifies the setup and ongoing management for users, providing a straightforward mechanism to manage NFS storage configurations without needing to handle complex manual processes.NFSStorageClass
resource. This helps maintain system integrity and prevent configuration drift, while also simplifying compliance by funneling all changes through a controlled process.What is the expected result?
NFSStorageClass
resource.Checklist