Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding types to the project #726

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

adding types to the project #726

wants to merge 4 commits into from

Conversation

exx8
Copy link

@exx8 exx8 commented Oct 5, 2019 •
edited
Loading

I've written types for the project based on the latest version.

  1. I assumed the formatArgs accepts Array of strings.
  2. this is still experimental, and I wish somebody will check my browser checking on index.d.ts as it is a bit hack.

solves #669

@coveralls
Copy link

coveralls commented Oct 5, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 87.692% when pulling ec7a30b on exx8:types into 5c7c61d on visionmedia:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.692% when pulling 032024e on exx8:types into 5c7c61d on visionmedia:master.

@Apollon77 Apollon77 mentioned this pull request Aug 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@818Nawaf 818Nawaf 818Nawaf approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@exx8 @coveralls @818Nawaf