Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/splits #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature/splits #36

wants to merge 3 commits into from

Conversation

deavmi
Copy link
Owner

@deavmi deavmi commented Jul 3, 2023

When doing any of the following:

  • channelMessage(string, stringp[])
  • channelMessage(string, string)
  • directMessage(string, string[])
  • directMessage(string, string)

Ensure the first option, message's encoded size (also note that calling encode can throw an exception ifinvalid characters present or at least will be able to once bugfix/stripper is merged) is l <=512 and if over then construct multiple split calls to self

- Added TODO to `sendMessage(Message)`
- Removed TODOs from `sendMessage(Message)`
- Added TODOs to to `channelMessage(string, stringp[])`, `channelMessage(string, string)`, `directMessage(string, string[])` and `directMessage(string, string)`
@deavmi deavmi added the enhancement New feature or request label Jul 3, 2023
@deavmi deavmi self-assigned this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant