Remove redundant nil check in LocalFlagNames

From the Go specification: "1. For a nil slice, the number of iterations is 0." [1] Therefore, an additional nil check for before the loop is unnecessary. [1]: https://go.dev/ref/spec#For_range Signed-off-by: Eng Zer Jun <[email protected]>
dearchap · Sep 16, 2023 · 3da6a64 · 3da6a64
1 parent a8de551
commit 3da6a64
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/command.go b/command.go
@@ -922,11 +922,9 @@ func (cmd *Command) LocalFlagNames() []string {
 	cmd.flagSet.Visit(makeFlagNameVisitor(&names))
 
 	// Check the flags which have been set via env or file
-	if cmd.Flags != nil {
-		for _, f := range cmd.Flags {
-			if f.IsSet() {
-				names = append(names, f.Names()...)
-			}
+	for _, f := range cmd.Flags {
+		if f.IsSet() {
+			names = append(names, f.Names()...)
 		}
 	}