Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support redis password when trying to connect the queue server #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deng-zy
Copy link

@deng-zy deng-zy commented Feb 26, 2016

No description provided.

@@ -13,6 +13,7 @@ def get_redis_via_sentinel(db,
socket_timeout=0.1,
redis_class=StrictRedis,
connection_pool_class=SentinelConnectionPool,
password=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also need to add password support to the celery configuration?

@blatinier
Copy link

Interested here :)
Forking gordon-zhiyong version in our local depot for now.

For information, to use it you must set the CELERY_REDIS_PASSWORD param.

@junhe1026
Copy link
Contributor

@blatinier hmm, CELERY_REDIS_PASSWORD seems to be deprecated and removed in celery version 4.0.

@miki725
I think there is no need to make extra effort to support celey pasword configuration, cuz we are able to pass password directly to the BROKER_URL.
One way that works for me on the basis of @gordon-zhiyong 's effort is as follows:

BROKER_URL = 'redis-sentinel://:{password}@redis-sentinel:26379/12'.format(password=your_redis_sentinel_password)

@cloverstd
Copy link

@junhe1026 Hi, I use URL Schema with password for BROKER_URL, but it could not work.

https://github.com/dealertrack/celery-redis-sentinel/blob/master/celery_redis_sentinel/redis_sentinel.py#L208

There are no password params pass to Sentinel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants