Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grants.md for Redshift roles and groups #5739

Closed
wants to merge 4 commits into from

Conversation

psaintjust
Copy link

Added instructions for using grants with Redshift roles and groups.

What are you changing in this pull request and why?

Added instructions for using grants with Redshift roles and groups since it requires a Redshift specific syntax.

Checklist

Added instructions for using grants with Redshift roles and groups.
@psaintjust psaintjust requested a review from a team as a code owner July 4, 2024 12:47
Copy link

welcome bot commented Jul 4, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 10:10am

@github-actions github-actions bot added the content Improvements or additions to content label Jul 4, 2024
@runleonarun runleonarun added the new contributor Label for first-time contributors label Jul 4, 2024
@github-actions github-actions bot added the size: small This change will take 1 to 2 days to address label Jul 4, 2024
@mirnawong1
Copy link
Contributor

Thanks for opening up this pr @psaintjust ! I'll take a look at this for you!

@mirnawong1
Copy link
Contributor

raised this question in internal slack for additional insight

@mirnawong1
Copy link
Contributor

hey @psaintjust ! this is a great pr and i appreciate you opening it up! after a conversation with @dbeatty10 and the internal team, we want to hold off on documenting how to use roles and groups in Redshift until dbt-redshift #415 and dbt-redshift #626 are resolved.

This is mostly because:

  • If there’s a code change, the syntax could break
  • The below syntax isn’t the intended behavior as of right now, That this syntax doesn’t raise an error is completely accidental:
    {{ config(grants = {‘select’: [‘ROLE role_analyst’]}) }}
  • Unlike Redshift users, grants done in this manner will remain forever unless they are revoked manually. This is exactly the opposite of our intention with the grants feature.

so i’m going to close this pr out, however, i’ve added your suggestions to this issue here, which is being blocked by development. let me know if you have any questions at all and i really appreciate your thorough contribution!

@mirnawong1 mirnawong1 closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants