Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description to pg catalog flag #913

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Add description to pg catalog flag #913

merged 5 commits into from
Sep 18, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

We added a required field to behavior flags.

Solution

Fill in the description for now. We can replace this with the url to the behavior flag on docs.getdbt.com once the docs are updated.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Sep 17, 2024
@mikealfare mikealfare requested a review from a team as a code owner September 17, 2024 22:16
@cla-bot cla-bot bot added the cla:yes label Sep 17, 2024
@mikealfare mikealfare added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Sep 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@cla-bot cla-bot bot added the cla:yes label Sep 18, 2024
@mikealfare
Copy link
Contributor Author

An example of the warning:
image

@mikealfare mikealfare enabled auto-merge (squash) September 18, 2024 18:14
@mikealfare mikealfare merged commit fb1b5ae into main Sep 18, 2024
25 of 26 checks passed
@mikealfare mikealfare deleted the add-description-to-pg-catalog-flag branch September 18, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikealfare @colin-rogers-dbt